fix: Unblock the releases on Node Bigquery#7946
Open
danieljbruce wants to merge 30 commits intomainfrom
Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A feature flag is added that turns on high precision timestamp support if an environment variable is set. High precision timestamp client library support is currently blocking releases due to #7286 because the feature provided by the service is not generally available yet. Therefore, we are turning this feature off by default and allowing users to turn it on by setting an environment variable when it becomes generally available.
Impact
This unblocks releases for Node Bigquery.
Testing
The relevant tests added for high precision timestamps are only turned on when the high precision timestamp environment variable is set.
We verify that the changes are okay with two set of test runs.
First, the tests should pass for a project that doesn't service high precision timestamp requests and doesn't have the high precision timestamp environment variable set.
Second, the tests should pass for a project that DOES service high precision timestamp requests and DOES have the high precision timestamp environment variable set.